craftcms / craftcms/cms

Queue manager: Links are not friendly

Open
#5,731 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug severity:minor
Dominant language
PHP
Stars
3.6k
Forks
705
Avg merge
1d 5h
Merged PRs (30d)
134

Description

You're pushing state onto the browser history, but clickable links don't have real hrefs, so you can't, for instance, open the link in a new tab.

Also, once I'm in a job detail, when I click the back button (the one in the CP, not the browser back), I get a state like this:

Screen Shot 2020-02-28 at 7 55 20 AM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in the control-panel queue manager: inspect links from the job list and the back button from a job detail. Confirm that links expose real destinations for new-tab use and that the control-panel back action restores the expected queue state.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.