craftcms / craftcms/cms

3.4 beta: when viewing a user in the CP, 1password wants to populate the username

Open
#5,365 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.6k
Forks
705
Avg merge
1d 5h
Merged PRs (30d)
134

Description

Description

3.4.0-beta.4

When opening the edit view for a user, the 1Password Chrome extension pops up a select on the user name.

image

This happens on page load when opening up an existing user (above) or a new user (below)

image

It also happens when manually focusing the field after focus is somewhere else.

It might be okay when registering a new user; when open an existing user, there's some risk of inadvertently changing the name (of course the admin could just undo or not save, but still)

Know that other times I've reported 1Password-related unexpected Craft UX it's turned out to be a limitation or bug with 1Password itself. I figure that since you apparently have their ear it's most effectively to report things here — you know all the details about the field in question. Let me know if you'd rather I take this issue somewhere else.

Steps to reproduce
  1. In Chrome with the 1Password extension installed go Settings > Users > (a user or create a new one)
Additional info
  • Craft version: 3.4.0-beta.4
  • PHP version: 7.2.24
  • Database driver & version: MySQL 5.7.28
  • Plugins & versions:
    • Redactor 2.5.x-dev

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior in Chrome with the 1Password extension installed by opening Settings > Users and viewing an existing user or creating a new one. Compare the username field on page load and when it receives focus, then verify that the extension no longer offers to populate the field unexpectedly for an existing user.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.