craftcms / craftcms/cms

No validation errors for not currently selected sites when saving drafts

Open
#5,140 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug severity:normal sites :earth_americas:
Dominant language
PHP
Stars
3.6k
Forks
705
Avg merge
1d 5h
Merged PRs (30d)
134

Description

Description

This is part 2 of #5097

It looks like when saving drafts validations are only performed for the entry on the currently selected site, but not for others.

Steps to reproduce
  1. Setup: Two sites (en/de), a section with a required translatable field
  2. Create a new entry in en, fill out title and the field
  3. Switch to de
  4. Delete content in the required field
  5. Switch to en
  6. Click save => entry gets saved without errors.
    There is no validation error for the empty field in de

Thanks.

Additional info
  • Craft version: 3.3.11
  • PHP version: 7.2.14
  • Database driver & version: MySQL 5.7.14
  • Plugins & versions: none

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two-site en/de draft-saving scenario with a required translatable field, then trace the draft-save validation path for entries across sites. Done means saving from en reports the missing required value in de instead of saving silently.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, internationalization, localization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.