craftcms / craftcms/ckeditor

Matrix blocks with multiple redactor fields aren't all converted

Open
#349 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
PHP
Stars
47
Forks
32
PR merge metrics
No merged PRs in 30d

Description

Description

If a matrix block contains more than 1 redactor field, running php craft ckeditor/convert will only convert 1 of them. Note that they all seem to be converted in the project config so running the command again doesn't find them, however, only 1 of them is actually converted in the database.

Steps to reproduce
  1. Create a matrix field with a single block containing 2 redactor fields
  2. Run php craft ckeditor/convert
Additional info
  • Craft version: 4.13.8
  • PHP version: 8.2.27
  • Database driver & version: MariaDB 10.11.10
  • Plugins & versions: Redactor 3.1.0, CKEditor 3.10.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with a matrix block containing two redactor fields, then trace the php craft ckeditor/convert entry point and compare the project configuration with the database result. Done means every redactor field in the block is converted, and a regression test covers multiple fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, databases
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.