craftablescience / craftablescience/sourcepp

Filepath arguments have flaky support for non-ascii strings

Open
#89 0 comments 0 reactions 1 assignee View on GitHub

@craftablescience is already working on this.

Since Dec 4, 2025.

bug
Dominant language
C++
Stars
139
Forks
32
Avg merge
2d 11h
Merged PRs (30d)
7

Description

We discussed this on the discord, just wanted to make an issue abt it. The fix is to overload to std::filesystem::u8path as you stated.

Edit: the solution is to switch to using std::filesystem::path for all filesystem path arguments.

  • bsppp
  • fspp
  • gamepp
  • kvpp
  • mdlpp
  • sndpp
  • sourcepp
  • steampp
  • toolpp
  • vcryptpp
  • vpkpp
  • vtfpp

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.