crabbly / crabbly/Print.js

InstallTrigger to detect Firefox is deprecated

Open
#690 0 comments 2 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.5k
Forks
688
PR merge metrics
No merged PRs in 30d

Description

To detect Firefox, Print.js use **InstallTrigger** but it's deprecated.

Here https://bugzilla.mozilla.org/show_bug.cgi?id=1754441#c30 Dennis Schubert said

> If no feature detection is possible, I agree that this is a bit of a bad spot to be in. In those cases, running the simplest user-agent based test, something like
> `const isFirefox = /firefox/i.test(navigator.userAgent);`
> is probably the best way here.

> Relying on Firefox-only properties to detect the browser itself might look like an easier solution, but unfortunately it has the potential of breaking down the line - or it can force the browser developers to keep a non-standard property around just for compatibility reasons, which also isn't great.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.