cqframework / cqframework/cql-tests
Wrong Expected Output for Properly Includes And Properly Included In for Boundary Values
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 7
- Forks
- 8
- Avg merge
- 12d 5h
- Merged PRs (30d)
- 2
Description
The following test expect incorrect output:
- TimeProperContainsFalse
- TimeProperContainsPrecisionFalse
- TimeProperInFalse
- TimeProperInPrecisionFalse
One example:
<test name="TimeProperContainsFalse" version="1.0">
<capability code="interval-operators"/>
<expression>Interval[@T12:00:00.000, @T21:59:59.999] properly includes @T12:00:00.000</expression>
<output>false</output>
</test>
According to the spec for Properly Includes (a.k.a. ProperContains):
For the interval-point overload, this operator returns true if the interval contains (i.e. includes) the point, and the interval is not a unit interval containing only the point.
Based on that definition, the above test (and other linked tests) should expect true, not false.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open tests/cql/CqlIntervalOperatorsTest.xml and inspect the four linked cases around lines 1770-1822, then compare their expected values with the Properly Includes specification. Update the incorrect expected outputs and verify that all four boundary-value tests expect true.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- xml
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100