cqframework / cqframework/cql-tests-runner
Test Runner Not Detecting Equal DateTimes (+00:00 vs Z)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 5
- Forks
- 3
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 2
Description
When running the test CqlArithmeticFunctionsTest:MaxValue:DateTimeMaxValue, the test runner reports:
Test CqlArithmeticFunctionsTest:MaxValue:DateTimeMaxValue status: fail expected: @9999-12-31T23:59:59.999Z actual: @9999-12-31T23:59:59.999+00:00
My engine is returning the following result:
{
"resourceType": "Parameters",
"parameters": [
{
"extension": [
{
"url": "http://hl7.org/fhir/StructureDefinition/cqf-cqlType",
"valueString": "System.DateTime"
}
],
"name": "return",
"valueDateTime": "9999-12-31T23:59:59.999+00:00"
}
]
}
I suspect that the issue is that my DateTime uses offset +00:00, but the runner is expecting Z. Since these are equivalent, the runner should detect them as equal.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running CqlArithmeticFunctionsTest:MaxValue:DateTimeMaxValue and trace the test runner's DateTime comparison for the reported expected and actual values. Done means equivalent UTC representations such as Z and +00:00 are treated as equal without changing the CQL result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100