cqframework / cqframework/cql-tests-runner

Test Runner Not Detecting Equal Concept Values

Open
#81 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
5
Forks
3
Avg merge
2d 16h
Merged PRs (30d)
2

Description

When running the test CqlTypeOperatorsTest:ToConcept:CodeToConcept1, the test runner reports:

Test CqlTypeOperatorsTest:ToConcept:CodeToConcept1 status: fail expected: Concept {
                                        codes: Code { code: '8480-6' }
                                } actual: { codes: [Array], display: undefined }

My engine is returning the following result:

{
  "resourceType": "Parameters",
  "parameters": [
    {
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/cqf-cqlType",
          "valueString": "System.Concept"
        }
      ],
      "name": "return",
      "valueCodeableConcept": {
        "coding": [
          {
            "code": "8480-6"
          }
        ]
      }
    }
  ]
}

According to the CQL IG FHIR type mapping, System.Concept maps to FHIR.CodeableConcept, so I believe my engine is returning the correct result to represent ToConcept(Code { code: '8480-6' }).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing CqlTypeOperatorsTest:ToConcept:CodeToConcept1 and inspect the test runner's value-comparison logic. Compare the expected Concept with the actual FHIR CodeableConcept shown in the issue; done means equivalent concept values are recognized as equal and the test passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.