cqframework / cqframework/cql-tests-runner

Arithmetic function testing error breakdown (CqlArithmeticFunctionsTest).

Open
#59 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
5
Forks
3
Avg merge
2d 16h
Merged PRs (30d)
2

Description

CqlArithmeticFunctionsTest fails commentary:

  1. "passCount": 181,
    "skipCount": 10,
    "failCount": 21,
    "errorCount": 0

  2. Failing tests:
    17 fails "actual": "EvaluationError:FHIR R4 does not support Long/Integer64 values" these should be erroring because longs are not part of r4
    AbsLong
    Add1L2L
    Add1L1L
    LongMinValue
    LongMaxValue
    Modulo4LBy2L
    Multiply2LBy3L
    Multiply1By1L
    Negate1L
    NegateMaxLong
    NegateNeg1L
    PredecessorOf1L
    Power2LTo2L
    Power2LTo3L
    Subtract1LAnd1L
    SuccessorOf1L
    TruncatedDivide10LBy3L

    Known engine issues:
    Divide1Q1Q actual is showing units of g/cm3 which should be 1 as in expected - comment in test referring to discussion in issues
    Multiply1CMBy2CM actual is cm not cm2 which it should be - comment in test referring to making the units multiply

    Various fails:
    HighBoundaryDateTimeMillisecond (Z in actual, not in expected)
    LowBoundaryDateTimeMillisecond (Z in actual, not in expected)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running CqlArithmeticFunctionsTest and compare its 21 failures with the breakdown in this issue. Inspect the assertions for the Long/Integer64 cases, the two unit-calculation cases, and the boundary DateTime cases, including the referenced test comments. Done means the expected error or value matches the intended CQL R4 behavior and the full test breakdown passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.