cqframework / cqframework/cql-execution
ELM Tests for Quantity and Ratio don't test ELM
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 84
- Forks
- 38
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 1
Description
The ELM tests for Quantity and Ratio (test/elm/quantity/quantity-test.ts and test/elm/ratio/ratio-test.ts) don't actually interact w/ any compiled CQL, ELM JSON, or even their respective ELM classes (src/elm/quantity.ts and src/elm/ratio.ts). They are really just testing the datatype classes and math utils.
These tests should be reviewed to see if they provide unique value or if they are redundant with existing unit tests elsewhere. Tests that are redundant should be deleted. Tests that are not redundant should be moved to more appropriate tests suites (not ELM). New tests should be added that use real CQL and ELM JSON to verify that CQL Quantities and Ratios are properly converted to their respective data types when executed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review test/elm/quantity/quantity-test.ts and test/elm/ratio/ratio-test.ts alongside src/elm/quantity.ts and src/elm/ratio.ts, then compare their coverage with existing unit tests. Remove redundant cases, move unique datatype or math tests to appropriate suites, and add execution tests using real CQL and ELM JSON; done means Quantity and Ratio conversion is verified through execution.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100