cqframework / cqframework/cql-execution

Engine cannot tell if whole numbers are Integers or Decimals

Open
#204 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
84
Forks
38
Avg merge
1d 20h
Merged PRs (30d)
1

Description

Since we use standard JavaScript number, we lose the distinction of integer vs decimal. For example, the Decimal 2.0 just becomes the number 2 in the JS runtime -- and we can't tell if it is supposed to be a decimal or integer. This affects operations like predecessor and successor, as well as operations that check for overflows and underflows (since integers and decimals have different min/max).

This will likely require us to integrate a more sophisticated representation of numbers and may be a big deal.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining how the JavaScript number representation reaches predecessor, successor, and overflow or underflow checks. Done means the engine can preserve whether a whole value is an Integer or Decimal and apply the corresponding numeric bounds.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.