cqframework / cqframework/cqf-tooling

Vale Set Generator giving error from certain XLSX files from VASC

Open
#519 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
22
Forks
26
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Vale Set Generator giving error from certain XLSX files from VASC

To Reproduce
Steps to reproduce the behavior:

  1. Download Value Set from VSAC, eg. https://vsac.nlm.nih.gov/valueset/2.16.840.1.113762.1.4.1034.51/expansion/latest
  2. Run VSAC tooling to generate the value set
  3. Error received Unknown CodeSystem name: Code System

The excel file has an extra row 9, that is causing the tooling to read the header of the table marked "Code System". Deleting this row fixes this error

Expected behavior
The tooling should work on excel sheets downloaded from VSAC, without making any changes in the excel file

Desktop (please complete the following information):

  • OS: MacOS 12.6.8
  • Java Version 9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Vale Set Generator's XLSX parsing and reproduce the failure using the VSAC value set linked in the issue. Trace how the extra row containing the "Code System" header is interpreted, then verify that the VSAC spreadsheet generates successfully without deleting that row.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.