cqframework / cqframework/cqf-tooling
FlatMultiValueSetGenerator uses name for file name, should use id
@brynrhodes is already working on this.
Since Jan 15, 2021.
- Dominant language
- Java
- Stars
- 22
- Forks
- 26
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
The FlatMultiValueSetGenerator uses name for the generated file, but name is not unique, so the files generated are not unique. The generator should use the id of the value set for generation.
To Reproduce
Run the FlatMultiValueSetGenerator with the May2020 Update, which has value sets that have the same name, but different OIDs
Expected behavior
ValueSet files should be generated with their OID as the name:
valueset-1.2.3.4.5.6.7.json
Additional context
The relevant line to be changed is here:
https://github.com/cqframework/cqf-tooling/blob/develop/src/main/java/org/opencds/cqf/tooling/terminology/FlatMultiValueSetGeneratorBase.java#L240
The VSACValueSetGenerator illustrates an example of using the id:
https://github.com/cqframework/cqf-tooling/blob/develop/src/main/java/org/opencds/cqf/tooling/terminology/VSACValueSetGenerator.java#L129
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.