cpp-best-practices / cpp-best-practices/cppbestpractices

MSVC /Wall is not unusable because of standard library headers

Open
#144 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
8.8k
Forks
902
PR merge metrics
No merged PRs in 30d

Description

The current wording reads "`/Wall` - Also warns on files included from the standard library, so it's not very useful and creates too many extra warnings." – this reason does not seem to hold, because `/external` (i.e. `/external:anglebrackets`) exists and is effective in preventing `/Wall` warnings in the standard headers too.

A better reason to avoid `/Wall` would be a large number of informational diagnostics (i.e. https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4711?view=msvc-170) - but then again, these can be disabled individually.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.