cpp-best-practices / cpp-best-practices/cmake_template

myproject_ENABLE_ADDRESS_SANITIZER should be myproject_ENABLE_SANITIZER_ADDRESS

Open
#61 1 comment 2 reactions 0 assignees View on GitHub
Dominant language
CMake
Stars
1.8k
Forks
204
PR merge metrics
No merged PRs in 30d

Description

In this piece of code:

```
if(myproject_BUILD_FUZZ_TESTS)
message(AUTHOR_WARNING "Building Fuzz Tests, using fuzzing sanitizer https://www.llvm.org/docs/LibFuzzer.html")
if (NOT myproject_ENABLE_ADDRESS_SANITIZER AND NOT myproject_ENABLE_THREAD_SANITIZER)
message(WARNING "You need asan or tsan enabled for meaningful fuzz testing")
endif()
add_subdirectory(fuzz_test)

endif()
```

could it be that `myproject_ENABLE_ADDRESS_SANITIZER` should be `myproject_ENABLE_SANITIZER_ADDRESS and `myproject_ENABLE_THREAD_SANITIZER`should be `myproject_ENABLE_SANITIZER_THREAD` ?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.