Inconsistent parameter names for erase members of unordered containers
Nobody has claimed this yet.
- Dominant language
- TeX
- Stars
- 221
- Forks
- 813
- Avg merge
- 16h 4m
- Merged PRs (30d)
- 36
Description
The associative containers and the flat maps and sets all have:
constexpr size_type erase(const key_type& x);
template<class K> constexpr size_type erase(K&& x);
But the unordered containers have k and x for the same functions:
constexpr size_type erase(const key_type& k);
template<class K> constexpr size_type erase(K&& x);
This seems unnecessarily inconsistent. Either the unordered should use k for both (to be locally consistent), or use x for both (to be globally consistent).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the draft for the unordered-container erase declarations and compare their parameter names with the associative-container and flat-map/set declarations. Choose the consistent naming convention described in the issue, update the relevant standard wording, and verify that all affected erase declarations use the same convention.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100