cplusplus / cplusplus/draft

[mdspan.submdspan] Introduced `rank` should be _`rank`_ or dissolved

Open
#6,365 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TeX
Stars
221
Forks
813
Avg merge
16h 4m
Merged PRs (30d)
36

Description

Introduced rank should be rank or dissolved

[mdspan.submdspan.overview] introduces rank by "let"
in functions with a slices argument within [mdspan.submdspan].
rank is essentially sizeof...(slices)/sizeof...(SliceSpecifier).

In the same [mdspan.submdspan.overview],
it's then used to introduce another "let",
and never to be used again in [mdspan.submdspan].

There are actually many uses of sizeof...(SliceSpecifier) within [mdspan.submdspan]
that can be replaced with the introduced rank.
There's also one use of rank() (which is a different rank) while the introduced rank is in scope.

So I think either, the "let" rank should be renamed to rank or removed.
If not removed, we should consider replacing uses of sizeof...(SliceSpecifier) with rank.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the [mdspan.submdspan.overview] and [mdspan.submdspan] sections in the draft source. Review each introduced rank, the uses of sizeof...(SliceSpecifier), and the distinct rank() use; the wording should consistently either remove the unused let binding or rename and use it without ambiguity.

Written by the indexing model from the issue text.

Assessment

Tech stack
tex
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.