cplusplus / cplusplus/draft

[ranges] The explicity of the constructor needs to be consistent

Open
#5,505 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TeX
Stars
221
Forks
813
Avg merge
16h 4m
Merged PRs (30d)
36

Description

  • C++20 range adaptors such as filter_view, transform_view, take_view, take_while_view, drop_view, drop_while_view have no explicit keyword in their constructors.
    However, C++23 range adaptors such as chunk_­view, slide_view, and chunk_by_view all have the explicit keyword in their constructors.
    We should make them consistent.
  • Also, in the current CTAD of all range adaptors, only join_view has the explicit keyword, do we need to remove this seemingly redundant explicit?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the constructor declarations for the named C++20 and C++23 range adaptors, then inspect the CTAD declarations for all range adaptors, especially join_view. The issue is done when the constructor explicitness is made consistent and the question about join_view's CTAD explicitness has a documented resolution.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.