cplusplus / cplusplus/draft

[iterator.concept.winc] `I` used to represent both an integer-class and weakly_incrementable type

Open
#4,472 3 comments 0 reactions 1 assignee View on GitHub

@jensmaurer is already working on this.

Since Feb 5, 2021.

Dominant language
TeX
Stars
221
Forks
813
Avg merge
16h 4m
Merged PRs (30d)
36

Description

The first 2 exposition-only concepts, is-integer-like and is-signed-integer-like, have a template parameter named T.

Then comes the weakly_incrementable concept, with a template parameter named I.

The following normative paragraphs use I to define "integer-class", a subset of the T above. They rightfully reintroduce I each time, although the first one is unused.

Then, the final normative paragraph (before the Note: and Recommended practice:) uses I again, but this time to describe weakly_incrementable.

I is widely used throughout [iterator] to represent iterators. I believe those describing integer-class types should be renamed to T. This would be consistent with the is-integer-like concept.

Related: #3457.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.