coze-dev / coze-dev/coze-studio

CheckPermission的疑问

Open
#473 1 comment 0 reactions 1 assignee Claimed by @junwen-lee View on GitHub
question
Dominant language
TypeScript
Stars
21.6k
Forks
3.1k
PR merge metrics
No merged PRs in 30d

Description

api_auth_impl.go
CheckPermission 在做midware hander的时候,目前只是判断key存在则放行

apiKey, err := a.dao.FindByKey(ctx, req.ApiKey)
fun FindByKey
a.dbQuery.APIKey.WithContext(ctx).Where(a.dbQuery.APIKey.APIKey.Eq(key)).First()

1. 是否需要额外进行userid的判断,即session中的userid 需要和apikey中的userid吻合再放行
2. 这个地方每次经过拦截器都要查询数据库,是否性能会卡
3. 产线就这么直接查数据库 量级大的情况下 是不是太残暴了
4. 我代码瞎看的,如果理解错了,望海涵

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.