If slippage is too high why not trade less?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- typescript
- Domain
- blockchain
Research direction
Start by tracing the bot's maximum-slippage check and the path that compares trading the full token balance with 1% of it. Determine whether the intended behavior is to reduce trade size automatically, and define how the reduced amount and completion criteria should work before changing the trading flow.
Written by the indexing model from the issue text.
Description
I have encountered the silly situation where the trading bot will not trade because I gave it too many funds in the same token.
This happens because we have a maximum slippage tolerance. The bot checks this by comparing the price it gets when trading all of its balance in a token versus the price it would get if it traded only 1% of the balance. If the price in the full balance case is worse by too much it will not trade.
This feels wrong to me because it is likely that if the bot had fewer funds in the first place then the slippage wouldn't be a problem. The solution could be to trade low amounts by default instead of using the full balance.
Original issue https://github.com/gnosis/gp-v2-trading-bot/issues/23 by @vkgnosis
- Dominant language
- TypeScript
- Stars
- 15
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from cowprotocol/trading-bot
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
cowprotocol/trading-bot#13 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
All issues in cowprotocol/trading-bot
Similar issues
-
clawsweeper:fix-shape-clear clawsweeper:queueable-fix clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster no-stale P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 76/100
-
code-quality refactoring
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
github/gh-aw-firewall#8816 ·
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
vercel/react-tweet#225 ·