cowprotocol / cowprotocol/token-lists
No validation for fields on the Add tokens form
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
Discussed in https://cowservices.slack.com/archives/C0361CDG8GP/p1677685164664449
and in https://cowservices.slack.com/archives/C04DV3TL1MH/p1677685185496629
- Open Add token form from here https://github.com/cowprotocol/token-lists/issues/new/choose
- Fill in the fields with completely invalid data and submit the request
- Check the flow
AR: the request is successfully created. And add token PR is successfully created (#92).
ER: 2 options:
- add validation on the add token form to each field
- Auto-decline PR creation when any data is invalid on the form.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Add token form at the linked GitHub issue template and reproduce submission with invalid data. Review the resulting flow and add token PR #92 to understand the current behavior; done means invalid field data no longer creates an accepted request or PR, according to the chosen validation approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100