cowprotocol / cowprotocol/token-lists
Permit: use type `unsupported` rather than `false`
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
nit: if we want a more homogeneous definition, we can add an option here for `unsupported` so we don't need the `oneOff` which can give problems or is harder interface.
I should have said this in permit PRs, and also in the issue where you mentioned the schema. Anyways, is not too important, and yours is of course slightly more compact, so feel free to disregard the comment
Originally posted by @anxolin in https://github.com/cowprotocol/token-lists/pull/294#discussion_r1365898050
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the permit PR discussion linked in the issue and locate the current permit or schema definition in the repository. Compare how unsupported cases are represented today and inspect any related coverage; done means the schema consistently uses the proposed unsupported type without relying on the oneOff workaround.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100