cowprotocol / cowprotocol/token-lists
No validation for the address field on the Add image form
Open
Nobody has claimed this yet.
bug
good first issue
- Dominant language
- TypeScript
- Stars
- 16
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
- Open https://github.com/cowprotocol/token-lists/issues/new/choose
- Press on the Add image
- Fill in the address field with any value
- Select an image
- Submit the request.
AR: there is no validation for the Address field on
- format
- whether it belongs to the selected network or not
ER: it would be great to add these validations
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Add image form reached through the linked issue URL and inspect the address field together with the selected network. Reproduce the submission steps, then identify the existing form validation and network data used there. Done means invalid address formats and addresses from the wrong network are rejected before submission.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100