cowprotocol / cowprotocol/solana-programs
Reorganize order of accounts in instructions
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2
- Forks
- 1
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 32
Description
(Inspired by this comment.)
The order of accounts in the instructions of this program is a bit inconsistent with what other Solana programs usually do.
For example, the token program tends to put sysvar accounts towards the end (but still before variable-size account input). Source: https://docs.rs/spl-token/latest/spl_token/instruction/enum.TokenInstruction.html
This issue is resolved if we come up with a reasonable ordering standard for instruction account and change the builders to stick to it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the program's instruction account definitions and their builders, then compare their ordering with the SPL Token instruction reference linked in the issue. The work is done when a reasonable ordering standard has been agreed and the builders consistently follow it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100