cowprotocol / cowprotocol/solana-programs
Token accounts of a valid order can change mint
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 2
- Forks
- 1
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 32
Description
In the current implementation, the mints of sell and buy token accounts of a specific order UID may change between creation time and settlement time.
While this isn't really a problem for the programs, it may become one in other parts of the protocol, like accounting, user interface, or back-end. Unless the performance hit is very high, we want to prevent settlements with mutating mints.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the order UID through token-account creation and settlement in the Rust Solana programs, comparing the sell and buy mints at both points. Review any existing settlement tests, and consider the work done when settlement is prevented if either mint has changed while unchanged mints continue to settle.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- blockchain
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100