cowprotocol / cowprotocol/services
chore: Completely remove `executedFeeAmount` from API
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 318
- Forks
- 189
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 121
Description
Background
Once all executed fees are in the same token (surplus token), we can show following in the API:
- executedFee = executedFee + executedFeeAmount
- executedFeeAmount = 0 for ALL orders
as there are no clients that are interested in executedFeeAmount solely, and also, this field is only kept for legacy orders.
This effectively means we can remove executedFeeAmount from API.
Acceptance criteria
There is only ONE fee in the API that represents the total fee that was taken for execution of an order, and it's called executedFee.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by searching the repository for executedFeeAmount and trace the API schema and serialization references; done means the API exposes only executedFee as the total execution fee, including for legacy orders.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100