cowprotocol / cowprotocol/services
chore: Remove Error::ProtocolFeeOnStaticOrder
Open
Nobody has claimed this yet.
good first issue
tech-debt
- Dominant language
- Rust
- Stars
- 318
- Forks
- 189
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 121
Description
Background
This error should not happen after CIP38.
This removal should trigger dependent cleanup in the solvers interface (making "fee" non-optional)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Error::ProtocolFeeOnStaticOrder and the solvers interface, then trace all uses of the optional "fee" field. Confirm how CIP38 affects the error path before updating dependent cleanup. Done means the error and its references are removed, "fee" is non-optional throughout the interface, and the relevant Rust checks pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100