cowprotocol / cowprotocol/ethflowcontract
[Optimisation] fn deleteOrder() has unneeded parameter
Nobody has claimed this yet.
- Dominant language
- Solidity
- Stars
- 5
- Forks
- 7
- Avg merge
- 9h 41m
- Merged PRs (30d)
- 1
Description
deleteOrder() has an input variable "quoteId" of the ethflow.Data. And this variable is not needed. We could optimize for gas and take the variable out.
But IMO, it's not worth it, as this would require defining another EthflowOrder library data type and the gas overhead is quite low
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at deleteOrder() and the ethflow.Data definition. Assess whether removing quoteId requires another EthflowOrder library data type, then check the affected callers and the gas tradeoff. Done means the signature and related data types are consistently updated only if the optimization is worthwhile.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- solidity
- Domain
- blockchain
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100