cowprotocol / cowprotocol/ebbo
Add protocol (and integrator) fee to uniform directional price test
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Under CIP-38, we need to check for directional prices. The implementation in #97 does not account for protocol fees. Per the CIP those fees do enter the rule on directional price.
The main blocker for implementing this is availability of protocol fee information from the API.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the directional price implementation from #97 and the API's available protocol fee information. Check the CIP-38 rule and update the uniform directional price test to account for protocol and integrator fees; done means the test reflects those fees correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100