cowprotocol / cowprotocol/ebbo

Reference solver does not handle fees of partial fills

Open
#69 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Currently, quasimodo does not propose a fee for partially fillable orders. This leads to increased surplus resulting in alerts.

We should either fix quasimodo to handle partially fillable orders correctly or do some post-processing of surplus and fees for reference solutions of partial fills.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by tracing how quasimodo produces reference solutions for partially fillable orders and how surplus and fees are calculated or post-processed. Done means partial fills receive correct fees and no longer produce inflated surplus alerts.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.