cowprotocol / cowprotocol/ebbo

Fix abstraction for EBBO test

Open
#32 0 comments 0 reactions 1 assignee View on GitHub

@shubhagarwal03 is already working on this.

Since Apr 24, 2023.

Dominant language
Python
Stars
6
Forks
1
PR merge metrics
No merged PRs in 30d

Description

On thing that is not yet clear to me is what the correct abstraction for the EBBO test should be.
Generally I think we should compare buy and sell amounts of an executed order with buy and sell amounts of alternative executions.

The buy and sell amounts for the executed order can always be read from on chain data. The buy and sell amount for alternative executions can be obtained differently. Examples for alternative executions include solutions proposed by other solvers and solutions computed after the fact by Quasimodo or other solvers.

This would mean that the different EBBO test would differ in how they compute buy and sell amounts. They could then use the same code for the comparison itself.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.