cowprotocol / cowprotocol/ebbo
Adapt tests to new solver competition data format
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 6
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
The format of the solver competitions table is changed in https://github.com/cowprotocol/services/pull/3049.
Some tests might depend on that data as they access competition_data["transactionHash"]. If they break, we might need to adapt them accordingly.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review PR 3049 to understand the new solver competition table format, then search the tests for accesses to competition_data["transactionHash"]. Run the affected tests and update any assumptions that no longer match the new data; done means the relevant test suite passes with the updated format.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100