cowprotocol / cowprotocol/dune-sync

Check if tests for orderbook queries are still correct

Open
#68 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Some tests were introduced in PR #64 , but due to a slight change in the volume cap with PR #67, some of the tests might not be correct anymore.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the tests introduced in PR #64 with the volume-cap change from PR #67. Start by reviewing those pull requests and the current orderbook-query tests; done means the tests accurately reflect the current volume-cap behavior and no outdated expectations remain.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.