cowprotocol / cowprotocol/dune-sync

Inconsitent types for order and batch rewards

Open
#65 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

We currently upload amounts in batch rewards as integers (see here) and the amounts for order rewards as strings (see here). If there is a technical reason for this we should add a comment in the code. If there is no such reason, we could change the code to be more consistent.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the amount definitions in src/models/batch_rewards_schema.py and src/models/order_rewards_schema.py at the referenced lines. First determine whether the integer-versus-string difference is technically required; if not, make the two schemas consistent, or document the reason in the code. Done means the rationale is explicit or both reward types use the same amount representation.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.