cowprotocol / cowprotocol/dune-sync
Last Sync - Improvements
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 5
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
@MartinquaXD raised some good (non-blocking) points of improvement for the already merged code in #12. Here I will try to summarize;
- No need for Optional Block Number. This is only used for testing purposes and the tests could be adapted instead of the return type.
- Throw error on invalid table name. I think the problem with this may be that our test tables write to a different directory (intentionally) so not to interfere with real data. I think we may want to keep this.... not sure.
- Look at when KeyError occurs
- Use Contract Deployment as default genesis block
I think items 1 and 4 are the most straight forward to change first, still not sure yet about the other two.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing pull request #12 and the linked discussions for the optional block number, invalid table names, KeyError behavior, and default genesis block. Inspect the implementation and tests affected by items 1 and 4, then confirm the unresolved decisions before making changes; done means the agreed behavior is implemented and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100