coverallsapp / coverallsapp/github-action

"Some checks were not successful" even if they were

Open
#95 1 comment 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
520
Forks
78
PR merge metrics
No merged PRs in 30d

Description

I am running the Coveralls GitHub action in a monorepo, setting the parallel flag to true so that I can run the coverage jobs in parallel and batch-upload them at the end of the GitHub workflow execution. Here's my integration script:

https://github.com/hifi-finance/hifi/blob/10e8767c3749a3bf6a5cfe2c1c151df5935be87a/.github/workflows/integration-contracts.yaml

The issue is that occasionally, even if the workflow executes successfully, the Coveralls integration shows a red cross icon on the main page of the repository:

hifi-finance/hifi red cross

The error being:

Some checks were not successful

But the checks are successful! If I take this CI execution as an example, we can see it ran as expected:

https://github.com/hifi-finance/hifi/actions/runs/1270454967

The error seems to indicate that the "flash-swap" and the "protocol" jobs failed somehow. But if I look them up:

I can see no error in the Coveralls website. This might be a bug in the GitHub integration of Coveralls when the coverage reports are uploaded in parallel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/integration-contracts.yaml and compare the parallel Coveralls uploads with the final workflow status from actions/runs/1270454967. Review Coveralls jobs 87391829 and 87391804 to trace why successful uploads produce a red repository check. Done means a successful parallel workflow no longer reports “Some checks were not successful.”

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.