coverallsapp / coverallsapp/github-action
Non-Unique value submitted as service_job_id
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 520
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
service_job_id is documented to be unique per job of a parallel build.
Github Actions do not seem to provide anything like that, so leaving it blank is the only way to go about it.
So instead of assigning GITHUB_RUN_ID to COVERALLS_SERVICE_JOB_ID(in https://github.com/coverallsapp/github-action/blob/master/src/run.ts#L48), it should probably be assigned to COVERALLS_SERVICE_NUMBER. Which also matches up with the parallel-finish step submitting it as build_num.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/run.ts line 48 and compare how GITHUB_RUN_ID is assigned to COVERALLS_SERVICE_JOB_ID with the parallel-finish step's use of build_num. Confirm the expected Coveralls fields and update the assignment so service_job_id is not populated with a non-unique value; verify the action's relevant behavior afterward.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, typescript
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100