coverallsapp / coverallsapp/github-action

Parallel invocations should not be failing the build

Open
#47 8 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
520
Forks
78
PR merge metrics
No merged PRs in 30d

Description

I'm trying to set up coveralls reporting so that we do multiple parallel invocations, and the final aggregate will pass / fail based on coverage increase/decrease.

Here is where I'm trying to set this up.
https://github.com/TypeStrong/ts-node/pull/1040
The workflow configuration:
https://github.com/TypeStrong/ts-node/blob/a1f5bc8d99f5473ac1716d0c0cc9a5e12f7c0f8a/.github/workflows/continuous-integration.yml#L55-L75

I run a matrix of tests with parallel: true and continue-on-error: true. I have a single parallel-finished: true invocation to aggregate the results. Only the latter should pass/fail.

Am I don't something wrong? Why are the parallel invocations failing my build? I want them to succeed if coverage is successfully reported, ignoring any increase / decrease.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/workflows/continuous-integration.yml lines 55-75 and compare the setup with pull request 1040. Trace how the matrix uses parallel: true, continue-on-error: true, and the single parallel-finished: true invocation; done means only the aggregate result controls the build while successful coverage reporting from parallel jobs does not fail it.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.