coverallsapp / coverallsapp/github-action

carryforward flag not working for one of my subprojects

Open
#209 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
520
Forks
78
PR merge metrics
No merged PRs in 30d

Description

We have a mono repo with a bunch of different packages and we've been using the carryforward flag to merge all our coverage data into a single dashboard. The system has been working great. I recently added another package to the repo, but carryforward isn't working for this package, and it's not showing up in the dashboard.

The package that is being ignored is objective_c. Its workflow is here (see the test-mac job). Here's an example build: https://coveralls.io/builds/67337093

Later in the same github actions run, a different package called ffigen generated this build: https://coveralls.io/builds/67337130. Ffigen's workflow is here (see the test-mac job).

Note that objective_c_tests is missing from the Subprojects list of the ffigen build, and if you expand the source tree, pkgs/objective_c/lib/src/ns_data.dart is uncovered, despite being 100% covered in the objective_c build. Seems that coveralls is just dropping the objective_c subproject.

Btw, both those builds were taken from this PR. The workflow logs are here (ObjC) and here (ffigen).

I know this is probably not a coveralls bug, and I'm just doing something wrong, but I'm stumped and not sure how to debug it further. Is there anything obviously wrong in my configs? Is there any way to get more information about what's going on, either from the dashboard or the workflow logs? Any help would be appreciated.

cc https://github.com/dart-lang/native/issues/1108

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the test-mac jobs in .github/workflows/objective_c.yaml and .github/workflows/ffigen.yml, focusing on their carryforward configuration. Review the linked Coveralls builds 67337093 and 67337130 and the corresponding workflow logs to determine why objective_c_tests is omitted. Done means the objective_c subproject appears in the ffigen build and its coverage is carried forward.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.