coverallsapp / coverallsapp/github-action

Action should support the global working-directory

Open
#122 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
520
Forks
78
PR merge metrics
No merged PRs in 30d

Description

Github has a global that it supports called working-directory. This enables you to run an action in a specified working directory.
This action seems to ignore it which leads to thing like this:

coverage-nodejs:
  defaults:
    run:
      working-directory: ./nodejs

  steps:
    - uses: actions/checkout@v2
    - uses: actions/setup-node@v3
    - run: yarn install --frozen-lockfile
    - run: yarn build
    - run: yarn jest --coverage
    - run: tail ./coverage/lcov.info
    #      ^-- this outputs the actual last few lines of the lcov.info successfully
    - uses: coverallsapp/github-action@master
      with:
        github-token: ${{ secrets.GITHUB_TOKEN }}
        path-to-lcov: ./nodejs/coverage/lcov.info
        #               ^-- ignoring working-directory here
        base-path: ./nodejs
        #          ^-- duplication of working-directory perhaps?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the workflow example in the issue and compare the action's handling of path-to-lcov and base-path with GitHub Actions' defaults.run. Verify the behavior using a workflow with working-directory set to ./nodejs; done means the action resolves the coverage path without requiring duplicated directory settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.