coverallsapp / coverallsapp/github-action
Difference in relevant lines calculation between python versions 3.7 and greater
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 520
- Forks
- 78
- PR merge metrics
- No merged PRs in 30d
Description
Description
Our pipeline runs coverallsapp action in parallel with several different versions of python. Noticed that after making a non-functional change to a file, (removed comment) our coveralls check was failing the build for a -0.0% decrease.
Difference Between Versions
Search results in a small difference the relevant lines are calculated between python versions:
3.7
3.8
The difference between the to are the method declaration lines. 3.6 and 3.7 seem to leave it out, while 3.8 and beyond include the line as "relevant". This is the only significant difference I can find between the passing coveralls checks (3.6, 3.7) and the failing checks, (3.8, 3.9)
Questions
- Can anyone shed any light on this issue?
- Is there a workaround besides increasing the failure threshold?
- Is this a bug?
- Am I misdiagnosing my coverage failures?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the Coveralls GitHub Action results for Python 3.7 and 3.8, focusing on how method declaration lines are counted as relevant. Check whether the discrepancy comes from the action or its coverage tooling, and document a confirmed cause and workaround for the failing coverage check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, python
- Domain
- ci-cd, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100