couchbaselabs / couchbaselabs/beer-sample-net

Shouldn't this be EndKey?

Open
#1 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
5
Forks
2
PR merge metrics
No merged PRs in 30d

Description

```
public IEnumerable GetAllByName(string startKey = null, string endKey = null, int limit = 0, bool allowStale = false)
{
IView view = GetView("by_name");
if (limit > 0) view.Limit(limit);
if (!allowStale) view.Stale(StaleMode.False);
if (!string.IsNullOrEmpty(startKey)) view.StartKey(startKey);

// this line here should be end key?
if (!string.IsNullOrEmpty(endKey)) view.EndKey(endKey);

return view;
}
```

https://github.com/couchbaselabs/beer-sample-net/blob/master/src/CouchbaseBeersWeb/Models/BreweryRepository.cs#L46

Contributor guide

No contributing guide indexed for this repository

Research direction

Open src/CouchbaseBeersWeb/Models/BreweryRepository.cs around line 46 and compare the GetAllByName parameters with the view calls. Confirm whether the current source already uses EndKey for endKey; done means the implementation and any relevant test clearly match the intended range behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
databases
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.