couchbaselabs / couchbaselabs/ForestDB-Benchmark

wrapper functions

Open
#14 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
33
Forks
21
PR merge metrics
No merged PRs in 30d

Description

The inner loop of `couchstore_save_documents` in every wrapper -- except ForestDB -- has a malloc/free pair and a bunch of memory copies.

Every wrapper -- except ForestDB -- gets two more malloc/free pairs and associated memory copies in the inner loop of `couchstore_walk_id_tree`, and WiredTiger gets another malloc and memory copy in `couchstore_open_document` nobody else has.

I won't speak for LevelDB or RocksDB, but any data copy is almost certainly unnecessary in WiredTiger's case.

At the least it would be utterly trivial to limit the malloc/free calls to a single call per set of documents or cursor traversal, or why aren't these buffers allocated per cursor?

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.