couchbase / couchbase/xdcrDiffer
Certificate for source may not be signed for loopback
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 9
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Description
// Only grab certificate if on a loopback device
if difftool.specifiedRef.IsHttps() && isURLLoopBack(options.sourceUrl) {
cert, err := utils.GetCertificate(difftool.utils, options.sourceUrl, options.sourceUsername,
options.sourcePassword, xdcrBase.HttpAuthMechPlain)
if err != nil {
return err
}
internalHttpsHostname, _, err := difftool.utils.HttpsRemoteHostAddr(options.sourceUrl, nil)
if err != nil {
return fmt.Errorf("unable to get httpsRemoteHostAddr: %v", err)
}
difftool.selfRef.Certificate_ = cert
refHttpAuthMech, defaultPoolInfo, _, err := difftool.utils.GetSecuritySettingsAndDefaultPoolInfo(options.sourceUrl,
internalHttpsHostname, difftool.selfRef.UserName(), difftool.selfRef.Password(),
difftool.selfRef.Certificates(), difftool.selfRef.ClientCertificate(), difftool.selfRef.ClientKey(),
difftool.selfRef.IsHalfEncryption(), difftool.logger)
This logic is incorrect as it is possible the source cluster's cert is invalid for loopback address.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the shown HTTPS and loopback branch, then trace GetCertificate, isURLLoopBack, and GetSecuritySettingsAndDefaultPoolInfo to understand how the source certificate is selected and validated. Done means the source certificate is not assumed valid merely because the source URL is loopback, with coverage added for an invalid loopback certificate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100