cosmos / cosmos/interchain-security

Moving Tests from Integration Tests

Open
#2,306 0 comments 1 reaction 0 assignees View on GitHub
scope: testing type: refactoring
Dominant language
Go
Stars
195
Forks
166
PR merge metrics
No merged PRs in 30d

Description

## Problem

Moving Tests from Integration Tests:
- [TestQueueAndSendSlashPacket](https://github.com/cosmos/interchain-security/blob/29e6028164a09dfaf47e26cc03fe132359938dc2/tests/integration/slashing.go#L647) doesn't need to be an integration test because it concentrates on the behavior of the QueueSlashPacket and GetPendingPackets methods without relying on the general state or interactions with other components.
- [TestOnRecvSlashPacketErrors](https://github.com/cosmos/interchain-security/blob/29e6028164a09dfaf47e26cc03fe132359938dc2/tests/integration/slashing.go#L337) doesn't need to be an integration test because it checks the behavior of the OnRecvSlashPacket method independently of the general state or interactions with other components.

## Closing criteria

Remove tests from integration and move them to unit tests if necessary.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.