cosmos / cosmos/ics23

return error on verification functions

Open
#29 1 comment 3 reactions 0 assignees View on GitHub
enhancement go
Dominant language
Rust
Stars
129
Forks
85
PR merge metrics
No merged PRs in 30d

Description

On the SDK implementation, we updated ICS23 to return an error when the verification failed. Would it be possible to do the same here now that we doing the migration?

cc: @cwgoes @AdityaSripal

https://github.com/confio/ics23/blob/9f53dd0c42123f18211f8671500d257696fd32e0/go/ics23.go#L36

https://github.com/confio/ics23/blob/9f53dd0c42123f18211f8671500d257696fd32e0/go/ics23.go#L52

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect the Rust verification functions involved in the ICS23 migration and compare their behavior with the linked go/ics23.go references at lines 36 and 52. The work is done when verification failures are returned as errors consistently with the SDK implementation; check the existing verification tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, rust
Domain
cryptography
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.