cosmos / cosmos/evm

Look into deduplicating antehandler checks

Open
#861 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
164
Forks
213
Avg merge
3d 58m
Merged PRs (30d)
12

Description

I wonder if the separate cost filter is still needed since we technically have one in the antehandler via a combination of https://github.com/cosmos/evm/blob/befde4fafa15c469a181708043224c95dea66c52/ante/evm/07_can_transfer.go, https://github.com/cosmos/evm/blob/61eedfcf340e8140b82e9e02478b086b81f63eda/ante/evm/08_gas_consume.go, and https://github.com/cosmos/evm/blob/491aa78f515250590ab235a865233418f387c288/ante/evm/fee_checker.go

_Originally posted by @vladjdk in https://github.com/cosmos/evm/pull/856#discussion_r2565772735_

Contributor guide

Open the contributing guide

Research direction

Start by reading ante/evm/07_can_transfer.go, ante/evm/08_gas_consume.go, and ante/evm/fee_checker.go, then locate the separate cost filter referenced by the issue. Compare the checks and their execution paths to determine whether they duplicate one another. Done means the redundancy is resolved or the issue records why the separate check is still needed.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
blockchain
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.