cosmos / cosmos/evm

Systemtests generalization makes tests hard to understand

Open
#738 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
164
Forks
213
Avg merge
3d 58m
Merged PRs (30d)
12

Description

imo the systemtests are a little too over-generalized. the following pattern is in pretty much every test:

```
s.BeforeEachCase

// some stuff

s.AfterEachCase

s.AfterEachAction
```

this makes it difficult to understand what the test is actually looking for. It would be much better imo to have for explicit calls:

```
s.CheckTxsPending

s.CheckTxsConfirmed
```

this way its clear what the test is checking for, and there is less mental overhead/jumping around code to figure out what the test is doing.

Contributor guide

Open the contributing guide

Research direction

Start by locating the systemtests and reviewing how BeforeEachCase, AfterEachCase, and AfterEachAction are used across them. Replace the generalized pattern with explicit checks such as CheckTxsPending and CheckTxsConfirmed, then run the system test suite; done means the tests clearly express what they check without the repeated lifecycle indirection.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
testing-qa
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.